[webkit-reviews] review granted: [Bug 51067] Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon() : [Attachment 77564] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 51067: Assertion failure: element->inDocument() in
AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067

Attachment 77564: Patch
https://bugs.webkit.org/attachment.cgi?id=77564&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77564&action=review

Looks good.  tHanks.

> LayoutTests/fast/dom/HTMLScriptElement/remove-in-beforeload.html:6
> +function obl()

Seems this could be a clearer name. :)

> LayoutTests/fast/dom/HTMLScriptElement/remove-in-beforeload.html:22
> +    s.setAttribute("onbeforeload", "obl()");
> +    s.setAttribute("onload", "fail()");
> +    s.setAttribute("onerror", "fail()");
> +    s.setAttribute("src", "foobar");

I think you can just do s.onbeforeload = obl, but this works too.