[webkit-reviews] review denied: [Bug 39855] Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D : [Attachment 77374] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 27 09:32:03 PST 2010
David Levin <levin at chromium.org> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 39855: Map GLsizei to long instead of unsigned long in
WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855
Attachment 77374: Patch
https://bugs.webkit.org/attachment.cgi?id=77374&action=review
------- Additional Comments from David Levin <levin at chromium.org>
The code changes looks fine, but it should have some tests.
It seems like you could call these method with negative values and verify that
you get a failure.
More information about the webkit-reviews
mailing list