[webkit-reviews] review denied: [Bug 44610] Malformed SVG causes crash in updateContainerOffset : [Attachment 77486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 27 04:15:44 PST 2010


Dirk Schulze <krit at webkit.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 44610: Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610

Attachment 77486: Patch
https://bugs.webkit.org/attachment.cgi?id=77486&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77486&action=review

LGTM. But reviewing the patch gives following error: Can't expand. Unable to
apply patch to tip of tree.
Can you check if it is still possible to apply the patch to tot?

And a short snippet left

> LayoutTests/svg/dom/recursive-use-expected.txt:1
> +Survived the crash!

Shouldn't it be. "Did not crash!"? IIRC we don't want a crash at all ;-)


More information about the webkit-reviews mailing list