[webkit-reviews] review requested: [Bug 46061] svn-apply updates date of wrong change log entry for a change log diff that contains two consecutive entries with the same author and date : [Attachment 77480] Patch with test cases

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 46061: svn-apply updates date of wrong change log entry for a change log
diff that contains two consecutive entries with the same author and date
https://bugs.webkit.org/show_bug.cgi?id=46061

Attachment 77480: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=77480&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Moved unit test into new file
fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl because it tests
setChangeLogDateAndReviewer(fixChangeLogPatch()).

Note, this patch modifies the functionality of fixChangeLogPatch() to move
entries that are inserted earlier in a ChangeLog to the top of the file.
Therefore, future patches that deliberately insert a change log entry earlier
(why?) will not be landed by the commit-queue/webkit-patch as the author
intended. Instead, the author will need to land such a patch by hand.

Maybe we should consider outputting a warning message when svn-apply detects
this?