[webkit-reviews] review granted: [Bug 51625] [GTK] Add support for build-jsc : [Attachment 77464] Add build-jsc support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 26 20:30:17 PST 2010


Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51625: [GTK] Add support for build-jsc
https://bugs.webkit.org/show_bug.cgi?id=51625

Attachment 77464: Add build-jsc support
https://bugs.webkit.org/attachment.cgi?id=77464&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77464&action=review

> Tools/Scripts/build-jsc:71
> +    $result = buildGtkProject("JavaScriptCore", "", "");

We should remove the the "($@)" from the function name
buildAutotoolsProject($@) and then we don't need to pass the empty string for
the second and third argument.


More information about the webkit-reviews mailing list