[webkit-reviews] review denied: [Bug 47368] onclick on option elements doesn't work : [Attachment 72858] First pass of manual test; updates based on comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 24 17:32:17 PST 2010


Eric Seidel <eric at webkit.org> has denied Dinu Jacob <dinu.jacob at Nokia.com>'s
request for review:
Bug 47368: onclick on option elements doesn't work
https://bugs.webkit.org/show_bug.cgi?id=47368

Attachment 72858: First pass of manual test; updates based on comments
https://bugs.webkit.org/attachment.cgi?id=72858&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sur ewhy you have a WebCore ChangeLog with no WebCore changes?	Also,
you need expected results for your new layout test.  You can use
window.eventSender to actually make the click.	It doesn't look lik eyour
layout test will actually work as-is. 
http://webkit.org/quality/testwriting.html   or see http://trac.webkit.org/wiki
for a bunch of information about writing layout tests.


More information about the webkit-reviews mailing list