[webkit-reviews] review denied: [Bug 46592] Convert CSSStyleSelector::applyProperty to use function pointers : [Attachment 77179] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 46592: Convert CSSStyleSelector::applyProperty to use function pointers
https://bugs.webkit.org/show_bug.cgi?id=46592

Attachment 77179: Patch
https://bugs.webkit.org/attachment.cgi?id=77179&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77179&action=review

I mean, should we just autogenerate this?  This fails on a zillion platforms,
suggesting you need to update other build systems.  I like the idea of reducing
the boilerplate in CSSStyleSelector, but if we're going to go to macros, we
might as well consider using a little python to autogenate the code instead
(like we do with DOM bindings and WebKit2 IPC).

> WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This is going to cause the cq to fail.	You should mention what tests this
fixes, or why testing is impossible (if that's the case).

> WebCore/css/CSSStyleApplicator.cpp:7
> + * CSSStyleSelector.cpp
> + *
> + *  Created on: Dec 9, 2010
> + *	   Author: macpherson
> + */
> +

You need a Google BSD copyright header here.