[webkit-reviews] review denied: [Bug 50869] [cairo] Rendering a lot of arcs on top of each other causes time outs in some tests : [Attachment 77010] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 50869: [cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

Attachment 77010: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=77010&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77010&action=review

> WebCore/ChangeLog:10
> +	   We avoid the situation where we have to render the same arc
> +	   multiple times over itself. Now it renders just one oval and
> +	   moves to the end angle.
> +

Are we guaranteed that this will produce the proper rendering? What if the
stroke is partially opaque? Is this hitting some weird slow path in Cairo?
Maybe it would be more accurate to break the stroke up into pieces and render
them in a loop?

> WebCore/platform/graphics/cairo/PathCairo.cpp:154
> +    float sweep = ea - sa;

This is a good opportunity to expand variable names into something more
readable.

> WebCore/platform/graphics/cairo/PathCairo.cpp:163
> +    } else

It's appropriate to use a "{" here since the block is more than one line.