[webkit-reviews] review denied: [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr. : [Attachment 77388] Latest patch for vs2010 build

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jake <jake at jakeonthenet.com>'s request
for review:
Bug 51116: Building webkit with Visual Studio 2010 fails due to ambiguous
'operator =' methods in RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51116

Attachment 77388: Latest patch for vs2010 build
https://bugs.webkit.org/attachment.cgi?id=77388&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77388&action=review

Thanks for the patch!

> WebCore/dom/Document.cpp:3175
> +	       newFocusedNode = (Node*) 0;

We don't use c-style casts.  Why is this code modifying the PassRefPTr anyway? 
We can call .clear() instead, I think?

> WebCore/dom/ViewportArguments.h:77
> +	   , userScalable((bool) ValueAuto)

Again, we don't use c-style casts.  We should either disable the failing
warning for the file, or we should use static_cast or find some better way to
avoid the error.