[webkit-reviews] review denied: [Bug 50519] [Qt] [WK2] WebKit2 enabled minimal build fails to link : [Attachment 76996] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 24 03:06:19 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 50519: [Qt] [WK2] WebKit2 enabled minimal build fails to link
https://bugs.webkit.org/show_bug.cgi?id=50519
Attachment 76996: proposed fix
https://bugs.webkit.org/attachment.cgi?id=76996&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76996&action=review
> JavaScriptCore/JavaScriptCore.pri:88
> - LIBS += -l$$JAVASCRIPTCORE_TARGET
> + LIBS += -Wl,-whole-archive -l$$JAVASCRIPTCORE_TARGET
-Wl,-no-whole-archive
I think this change is different from the rest of this patch. Please split up.
More information about the webkit-reviews
mailing list