[webkit-reviews] review granted: [Bug 50018] MathML: vertical alignment & bar thickness adjustments of fractions are needed : [Attachment 74749] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 24 03:01:18 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted François Sausset
<sausset at gmail.com>'s request for review:
Bug 50018: MathML: vertical alignment & bar thickness adjustments of fractions
are needed
https://bugs.webkit.org/show_bug.cgi?id=50018
Attachment 74749: Patch
https://bugs.webkit.org/attachment.cgi?id=74749&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74749&action=review
Please respond to or fix these comments before landing.
> WebCore/ChangeLog:8
> + Adjustments of the fraction bar default thickness and vertical
alignment.
> + https://bugs.webkit.org/show_bug.cgi?id=50018
> +
> + Test: mathml/presentation/fractions.xhtml
It would be nice if you explained what change you actually made. Like why is
this new change more correct?
> WebCore/mathml/RenderMathMLFraction.cpp:145
> + int adjustForThickness = m_lineThickness > 1 ?
static_cast<int>(m_lineThickness / 2) : 1;
Why static_cast<int> and not just int(m_lineThickness / 2) ?
More information about the webkit-reviews
mailing list