[webkit-reviews] review denied: [Bug 40082] [Qt] Dropdown box is seen twice in a webpage. : [Attachment 58719] Updated changelog.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 24 02:38:47 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Viatcheslav
Ostapenko <ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 40082: [Qt] Dropdown box is seen twice in a webpage.
https://bugs.webkit.org/show_bug.cgi?id=40082

Attachment 58719: Updated changelog.
https://bugs.webkit.org/attachment.cgi?id=58719&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=58719&action=review

The comment is very very detailed and not get out of touch with the code. In
WebKit we like comments to be concise and to the point.

Btw, is this still an issue? Can it be fixed in Qt?

> WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp:72
> +    void paint(QPainter*, const QStyleOptionGraphicsItem*, QWidget*) {}

Needs space between { and }. WebKit coding style.


More information about the webkit-reviews mailing list