[webkit-reviews] review granted: [Bug 50049] [Qt] Add SelectAll option to the context menu for the editor : [Attachment 74890] fix webkit2 build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 24 02:26:58 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 50049: [Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Attachment 74890: fix webkit2 build
https://bugs.webkit.org/attachment.cgi?id=74890&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74890&action=review

mac also seems to have this for TextArea and input fields, so r=me

> WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:302
> +    notImplemented();
> +    return "Select All";

Why does this have notImplemented???


More information about the webkit-reviews mailing list