[webkit-reviews] review requested: [Bug 51584] [Qt] Glyphs in vertical text tests are rotated 90 degrees clockwise : [Attachment 77406] initial patch to make vertical text work
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 24 00:24:20 PST 2010
Koan-Sin Tan <koansin.tan at gmail.com> has asked for review:
Bug 51584: [Qt] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=51584
Attachment 77406: initial patch to make vertical text work
https://bugs.webkit.org/attachment.cgi?id=77406&action=review
------- Additional Comments from Koan-Sin Tan <koansin.tan at gmail.com>
An initial patch to make vertical text work. There are many problems in this
patch, but it works.
1. Qt doesn't export font/text matrix (yet), so we have to rotate the QPainter
at least once for each QString
2. Qt doesn't export API to get GSUB tables (yet), it's not quite difficult to
do vertical glyph substitution
3. Currently, glyph positions use QFontMetrics to measure the width a
horizontal string. This is not quite. Should be able to measure the height of a
string with vertical layout
More information about the webkit-reviews
mailing list