[webkit-reviews] review denied: [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr. : [Attachment 77384] Second attempt at patch to fix nullptr_t related build issues on vs2010

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 23 16:43:50 PST 2010


Darin Adler <darin at apple.com> has denied Jake <jake at jakeonthenet.com>'s request
for review:
Bug 51116: Building webkit with Visual Studio 2010 fails due to ambiguous
'operator =' methods in RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51116

Attachment 77384: Second attempt at patch to fix nullptr_t related build issues
on vs2010
https://bugs.webkit.org/attachment.cgi?id=77384&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77384&action=review

The rest of my comments from the first patch still apply, except for the one
about the tab.

> WebCore/dom/Document.cpp:3175
> -	       newFocusedNode = 0;
> +	       newFocusedNode = (Node*) 0;

This change looks wrong. Could you tell me more about the warning?


More information about the webkit-reviews mailing list