[webkit-reviews] review granted: [Bug 51553] [chromium] LayoutTestController warning in float->int conversion : [Attachment 77359] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 23 13:32:28 PST 2010


Ryosuke Niwa <rniwa at webkit.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 51553: [chromium] LayoutTestController warning in float->int conversion
https://bugs.webkit.org/show_bug.cgi?id=51553

Attachment 77359: Patch
https://bugs.webkit.org/attachment.cgi?id=77359&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #4)
> I don't know, is that more common in WebKit?

I think so.

> 1) I wanted to stick the the behavior of the old code and
> 2) using references for that isn't allowed in Google style, so it didn't
occur to me.  :)

Ok, r=me. This change is simple enough.


More information about the webkit-reviews mailing list