[webkit-reviews] review denied: [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6 : [Attachment 77307] Proposed patch to make WebKitGtk+ build on Mac OS X

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 23 13:02:15 PST 2010


Mark Rowe (bdash) <mrowe at apple.com> has denied Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50867: [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

Attachment 77307: Proposed patch to make WebKitGtk+ build on Mac OS X
https://bugs.webkit.org/attachment.cgi?id=77307&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77307&action=review

> WebCore/platform/UUID.h:37
>  #include "PlatformString.h"

This change to UUID.h is simply not correct.  It’s unsafe to alter the PLATFORM
defines in individual files like this, even more so from a header file.


More information about the webkit-reviews mailing list