[webkit-reviews] review granted: [Bug 51550] Clean up the selection handling code : [Attachment 77355] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 51550: Clean up the selection handling code
https://bugs.webkit.org/show_bug.cgi?id=51550

Attachment 77355: Patch
https://bugs.webkit.org/attachment.cgi?id=77355&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77355&action=review

> WebKit2/Shared/SelectionState.h:39
> +	   , selectedRangeStart(static_cast<uint64_t>(-1))

Can we have a named constant for this? What does it mean? Is it ever exposed to
clients of the WK API?

> WebKit2/UIProcess/WebPageProxy.h:177
> +    // These are only used on Mac currently.

Seems like a silly comment just before #if PLATFORM(MAC). Is there something
more substantive to say about these functions?

> WebKit2/UIProcess/WebPageProxy.h:497
> +    // The current selection state.
> +    SelectionState m_selectionState;

Comment adds little. Leave it out?

> WebKit2/WebProcess/WebPage/WebPage.cpp:616
> +    location = static_cast<uint64_t>(-1);

Use that constant from above?