[webkit-reviews] review denied: [Bug 50636] contentEditable attribute fails to take "inherit" or invalid value : [Attachment 76536] fix patch 4

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 50636: contentEditable attribute fails to take "inherit" or invalid value
https://bugs.webkit.org/show_bug.cgi?id=50636

Attachment 76536: fix patch 4
https://bugs.webkit.org/attachment.cgi?id=76536&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76536&action=review

> WebCore/html/HTMLElement.cpp:651
> +    document()->updateLayoutIgnorePendingStylesheets();
> +

We definitely don't want to add updateLayout here.  We just got rid of this a
couple of months ago.

> WebCore/html/HTMLElement.cpp:679
> +
> +    document()->updateLayoutIgnorePendingStylesheets();
> +

Why do we want to call updateLayout here?

> WebCore/html/HTMLElement.cpp:712
> +    } else { // Set default value to "inherit".
> +	   ExceptionCode ec;
> +	   removeAttribute(contenteditableAttr, ec);

As Darin suggested, I don't think we should be removing the attribute.