[webkit-reviews] review denied: [Bug 51186] [chromium] Add asserts to test for contiguous-pixel Skia bitmaps. : [Attachment 77333] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 51186: [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186

Attachment 77333: Patch
https://bugs.webkit.org/attachment.cgi?id=77333&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77333&action=review

The "if" with an ASSERT as its sole arm is sloppy.

> WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:125
> +	   ASSERT(skiaBitmap->rowBytes() ==
SkBitmap::ComputeRowBytes(skiaConfig, skiaBitmap->width()));

ASSERT(!pixels || (skiaBitmap->rowBytes() == ...))