[webkit-reviews] review granted: [Bug 51523] check-webkit-style check for meaningless variable names in function declarations. : [Attachment 77312] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 51523: check-webkit-style check for meaningless variable names in function
declarations.
https://bugs.webkit.org/show_bug.cgi?id=51523

Attachment 77312: Patch
https://bugs.webkit.org/attachment.cgi?id=77312&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77312&action=review

Have you run this across the entire source base to check for false positives? 
I worry there may be a bunch.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:215
> +def _create_acronym(text):
> +    # Removes all lower case letters except those starting words.
> +    text = sub(r'(?<!\b)[a-z]', '', text)
> +    return text.upper()

Woh.  So this is used for finding "ec" used with "ExceptionCode", right? 
Probably best to add a comment about how it's used?

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1437
> +	   parameter_type = parameter[0]
> +	   parameter_name = parameter[1]
> +	   parameter_line_number = parameter[2]

Eeek.  This is a class. :)

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1440
> +	   if not len(parameter_name):
> +	       continue

if not parameter_name works too.

> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:-162
> -				'-multi_line_filter',

?  bogus filter?