[webkit-reviews] review denied: [Bug 44759] [EFL] Add custom network resource handler : [Attachment 66764] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Flavio Ceolin
<flavio.ceolin at profusion.mobi>'s request for review:
Bug 44759: [EFL] Add custom network resource handler
https://bugs.webkit.org/show_bug.cgi?id=44759

Attachment 66764: Patch
https://bugs.webkit.org/attachment.cgi?id=66764&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=66764&action=review

> WebCore/loader/FrameLoader.cpp:3546
> +#if PLATFORM(EFL)
> +bool FrameLoaderClient::shouldHandleScheme(const String& scheme)
> +{
> +    return false;
> +}
> +
> +void* FrameLoaderClient::handleScheme(const KURL url, String& mime, size_t*
bytesRead)
> +{
> +    return 0;
> +}
> +#endif

FrameLoaderClient functions should not be implemented in FrameLoader.cpp.  They
should be implemented in the client.

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:611
> +#if PLATFORM(EFL)
> +    if (frame->loader()->client()->shouldHandleScheme(protocol)) {
> +	   if (startCustomHandler(this, url))
> +	       return true;
> +    }
> +#endif

Why is this EFL specific?  The point of clients is to allow for different
behavior between ports without #ifs.