[webkit-reviews] review denied: [Bug 43204] Add symbol export macros to C++ DOM bindings : [Attachment 62999] Updated patch implementing suggestions by Nikolas

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 23 00:08:51 PST 2010


Adam Barth <abarth at webkit.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 43204: Add symbol export macros to C++ DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=43204

Attachment 62999: Updated patch implementing suggestions by Nikolas
https://bugs.webkit.org/attachment.cgi?id=62999&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please unify the preprocessor defines with JSC using WTF.  Code everywhere can
depend on WTF.	We use it all over the place.  You just have to play some
tricks with forwarding headers to get things to work.


More information about the webkit-reviews mailing list