[webkit-reviews] review granted: [Bug 51510] WebKit2 needs a way to return the main resource data : [Attachment 77284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 17:37:14 PST 2010


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 51510: WebKit2 needs a way to return the main resource data
https://bugs.webkit.org/show_bug.cgi?id=51510

Attachment 77284: Patch
https://bugs.webkit.org/attachment.cgi?id=77284&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77284&action=review

> WebKit2/WebProcess/WebPage/WebPage.cpp:952
> +	       if (RefPtr<SharedBuffer> buffer = loader->mainResourceData())

It would be better to move the RefPtr<SharedBuffer> declaration out so that it
has the same scope as the dataReference object itself.


More information about the webkit-reviews mailing list