[webkit-reviews] review granted: [Bug 25619] the shadow direction is negated in canvas context shadowOffsetY. : [Attachment 77160] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 25619: the shadow direction is negated in canvas context shadowOffsetY.
https://bugs.webkit.org/show_bug.cgi?id=25619

Attachment 77160: Patch
https://bugs.webkit.org/attachment.cgi?id=77160&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77160&action=review

> WebCore/platform/graphics/mac/FontMac.mm:183
> +	   // If shadows are ignoring transforms, then we haven't applied the Y
coordinate flip yet, so down is negative.

You never enter this code if shadows ignore transforms, because of the
!context->shadowsIgnoreTransforms() check above. So this comment is not
accurate.