[webkit-reviews] review granted: [Bug 51493] Cache snapshots of plugins before painting, to avoid script running during painting : [Attachment 77273] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 16:32:03 PST 2010


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 51493: Cache snapshots of plugins before painting, to avoid script running
during painting
https://bugs.webkit.org/show_bug.cgi?id=51493

Attachment 77273: Patch
https://bugs.webkit.org/attachment.cgi?id=77273&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77273&action=review

This looks good. I didn’t spot any obvious problems.

I do worry that the guarantees of no plug-in calls during the drawing process
here are indirect. I’d prefer a design that made a firmer guarantee that we
will draw without calling the plug-in.

> WebCore/rendering/RenderView.cpp:569
> +size_t RenderView::getRetainedWidgets(Vector<RenderWidget*>& renderWidgets)

Doesn’t seem all that useful to return the size. Why not just call size on the
vector?

> WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1576
> +	   switch (notification) {
> +	       case BeforeFlatteningPaint: {

WebKit coding style says to line the case up with the switch rather than
indenting.


More information about the webkit-reviews mailing list