[webkit-reviews] review requested: [Bug 48953] REGRESSION: Can't shadow/overwrite window.constructor (causes TypeError exception) : [Attachment 77274] Patch to allow setting window.constructor.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 16:29:15 PST 2010


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 48953: REGRESSION: Can't shadow/overwrite window.constructor (causes
TypeError exception)
https://bugs.webkit.org/show_bug.cgi?id=48953

Attachment 77274: Patch to allow setting window.constructor.
https://bugs.webkit.org/attachment.cgi?id=77274&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Added a new extended attribute to the JavaScript code generator called
ReplaceableConstructor that will generate a setJS<class>Constructor() method. 
Added this attribute to the DOMWindow interface.
Updated a test and added a new regression test.


More information about the webkit-reviews mailing list