[webkit-reviews] review denied: [Bug 51407] A check should be in place to ensure that a media engine error has not occurred after MediaPlayer::play() is called : [Attachment 77130] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 10:47:36 PST 2010


Alexey Proskuryakov <ap at webkit.org> has denied Lukas Sydorowski
<lsydorowski at rim.com>'s request for review:
Bug 51407: A check should be in place to ensure that a media engine error has
not occurred after MediaPlayer::play() is called
https://bugs.webkit.org/show_bug.cgi?id=51407

Attachment 77130: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=77130&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
A test that fails on at least one platform without this fix, and passes with it
would be enough. If this doesn't happen on any core platforms, perhaps the fix
should be in platform layer, not in HTMLMediaElement - making cross-platform
WebCore fixes that are not tested by build bots is almost the same as not
making them at all.

Marking r- due to lack of tests.


More information about the webkit-reviews mailing list