[webkit-reviews] review granted: [Bug 51390] Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style : [Attachment 77210] [PATCH] Comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 10:03:44 PST 2010


Joseph Pecoraro <joepeck at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 51390: Web Inspector: After scrolling new property value and cancelling,
removed property remains active in page style
https://bugs.webkit.org/show_bug.cgi?id=51390

Attachment 77210: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=77210&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77210&action=review

> WebCore/inspector/front-end/StylesSidebarPane.js:1854
> +	   // New properties applied via up/down have an originalPropertyText
and will be deleted later
> +	   // on, if cancelled, when the empty string gets applied as their
style text.

This comment would be better suited down below, in `applyStyleText`, next to
the usage of
the _hasBeenAppliedToPageViaUpDown function.


More information about the webkit-reviews mailing list