[webkit-reviews] review denied: [Bug 50745] Web Inspector: refactoring: make selected call frame a debugger model property : [Attachment 77215] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50745: Web Inspector: refactoring: make selected call frame a debugger
model property
https://bugs.webkit.org/show_bug.cgi?id=50745

Attachment 77215: Patch.
https://bugs.webkit.org/attachment.cgi?id=77215&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77215&action=review

> WebCore/inspector/front-end/CallStackSidebarPane.js:81
> +	   if (WebInspector.debuggerModel.currentlyHitBreakpoint())

I think isOnBreakpoint would be a better name than currentlyHitBreakpoint

> WebCore/inspector/front-end/DebuggerModel.js:192
> +	   this._callFrames = callFrames;

this._selectedCallFrameIndex should be reset when this._callFrames changes, r-
for this.