[webkit-reviews] review canceled: [Bug 34574] check-webkit-style should ignore underscore in Qt autotests : [Attachment 48287] Proposed patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 22 05:43:00 PST 2010
Shinichiro Hamaji <hamaji at chromium.org> has canceled review:
Bug 34574: check-webkit-style should ignore underscore in Qt autotests
https://bugs.webkit.org/show_bug.cgi?id=34574
Attachment 48287: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=48287&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
(In reply to comment #14)
> I think there are no reason we cannot land this patch. I guess Chris put cq-
just because this requires Bug 33684 closed. As the patch for Bug 33684 seems
to be landed already, I think we should be able to land this patch. I'll try.
Actually, this patch has already been landed:
http://trac.webkit.org/changeset/54482
The false-positives in Bug 40911 happened because we don't have qt/benchmark in
the exemption list.
More information about the webkit-reviews
mailing list