[webkit-reviews] review granted: [Bug 51452] check-webkit-style shouldn't complaint about underscores in variables in objective C files. : [Attachment 77194] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 51452: check-webkit-style shouldn't complaint about underscores in
variables in objective C files.
https://bugs.webkit.org/show_bug.cgi?id=51452

Attachment 77194: Patch
https://bugs.webkit.org/attachment.cgi?id=77194&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77194&action=review

Looks good. I think it's OK to land this patch as is. If we want a stricter
rule, we may be able to create another patch.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:933
> +	       self._is_objective_c = None

I feel we want a comment here which describes we'll guess this value in
is_objective_c.