[webkit-reviews] review canceled: [Bug 50619] [GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise : [Attachment 76327] proposed patch to make vertical text work on WebKitGtk+

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 21 17:16:44 PST 2010


Koan-Sin Tan <koansin.tan at gmail.com> has canceled Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50619: [GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=50619

Attachment 76327: proposed patch to make vertical text work on WebKitGtk+
https://bugs.webkit.org/attachment.cgi?id=76327&action=review

------- Additional Comments from Koan-Sin Tan <koansin.tan at gmail.com>
improvement over 76327:
1. remove recreateScaledFont()
2. avoid unnecessary vertical glyph lookup
3. handle shadow text


More information about the webkit-reviews mailing list