[webkit-reviews] review granted: [Bug 51431] -[WebBasePluginPackage isNativeLibraryData:] integer overflows on zero-sized data : [Attachment 77163] Proposed path

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron Zwarich (cpst)
<zwarich at apple.com>'s request for review:
Bug 51431: -[WebBasePluginPackage isNativeLibraryData:] integer overflows on
zero-sized data
https://bugs.webkit.org/show_bug.cgi?id=51431

Attachment 77163: Proposed path
https://bugs.webkit.org/attachment.cgi?id=77163&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77163&action=review

> WebKit/mac/Plugins/WebBasePluginPackage.mm:358
> +    if (!sizeInBytes)
> +	   return NO;
> +
>      Vector<uint32_t, 128> rawData((sizeInBytes - 1) / 4 + 1);

I would suggest just using (sizeInBytes + 3) / 4 rather than adding this null
check.