[webkit-reviews] review granted: [Bug 48434] Web Inspector: persist JavaScript breakpoints in frontend settings : [Attachment 77125] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 21 10:04:07 PST 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 48434: Web Inspector: persist JavaScript breakpoints in frontend settings
https://bugs.webkit.org/show_bug.cgi?id=48434

Attachment 77125: Patch.
https://bugs.webkit.org/attachment.cgi?id=77125&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77125&action=review

> WebCore/inspector/Inspector.idl:248
> +	   [notify, domain=Debugger] void breakpointResolved(out String
breakpointId, out String sourceID, out unsigned int lineNumber, out String
condition, out boolean enabled, out unsigned int originalLineNumber);

no need to pass condition and enable parameters as FE already knows them


More information about the webkit-reviews mailing list