[webkit-reviews] review denied: [Bug 48434] Web Inspector: persist JavaScript breakpoints in frontend settings : [Attachment 77102] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 48434: Web Inspector: persist JavaScript breakpoints in frontend settings
https://bugs.webkit.org/show_bug.cgi?id=48434

Attachment 77102: Patch.
https://bugs.webkit.org/attachment.cgi?id=77102&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77102&action=review

> WebCore/bindings/js/ScriptDebugServer.cpp:162
> +    intptr_t sourceIDValue = tokens[0].toIntPtr();

Please check for possible parse errors by passing &success flag into toIntPtr.

> WebCore/inspector/Inspector.idl:248
> +	   [notify, domain=Debugger] void breakpointResolved(out String
breakpointId, out String sourceID, out unsigned int lineNumber, out String
condition, out boolean enabled, out unsigned int originalLineNumber);

This method should report breakpointId if we have decided to address
breakpoints using ids in other places, otherwise the API is inconsistent.