[webkit-reviews] review requested: [Bug 50489] Move DocumentWriter to DocumentLoader : [Attachment 77034] Attempt to fix crashes #2

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 50489: Move DocumentWriter to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=50489

Attachment 77034: Attempt to fix crashes #2
https://bugs.webkit.org/attachment.cgi?id=77034&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Changes from the version that was committed and reverted:

FrameLoaderClientQt.cpp : Use m_frame->loader()->activeDocumentLoader() instead
of m_frame->document()->loader().  I believe that this will be safer if we
catch the loader in the middle of a navigation.

FrameLoaderClientGtk.h/cpp : Use an m_hasRepresentation boolean in the same way
the qt and chromium FrameLoaderClients do.  This should keep us from blowing
away our DocumentLoader in FrameLoader::init().

mrobinson and ossy, could I trouble you to verify this patch on your respective
platforms at your leisure?