[webkit-reviews] review requested: [Bug 50519] [Qt] [WK2] WebKit2 enabled minimal build fails to link : [Attachment 76996] proposed fix

[bugzilla-daemon at webkit.org]

Andras Becsi <abecsi at webkit.org> has asked  for review:
Bug 50519: [Qt] [WK2] WebKit2 enabled minimal build fails to link
https://bugs.webkit.org/show_bug.cgi?id=50519

Attachment 76996: proposed fix
https://bugs.webkit.org/attachment.cgi?id=76996&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
This patch also adds missing ENABLE(DATABASE) guards to fix the build. 

The linking issue is caused by a more complex problem.
In a default WebKit2 build WebCore links to the static jscore library, and
because some parts of WebCore (IconDatabase, ImageResizerThread,
DatabaseThread, LocalStorageThread, WorkerThread) are using createThread, the
linker doesn't remove the symbol so it is present afterwards when linking to
the static webkit2 lib, but in a minimal build these parts are guarded by
various ENABLE guards so because they are not needed in WebCore the linker
removes the symbol, but the WebKit2 ThreadLauncher nonetheless needs the
symbol, hence the linking fails.
This patch adds -whole-archive to JavaScriptCore.pri's addJavaScriptCoreLib to
explicitly force the linker to keep all the symbols of the archive.

This is only a workaround and should serve as a temporary solution until we
find a proper solution, how to refactor the build system.