[webkit-reviews] review granted: [Bug 50813] Web Inspector: creating conditional breakpoint doesn't work if breakpoint moves : [Attachment 76188] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 20 05:38:14 PST 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50813: Web Inspector: creating conditional breakpoint doesn't work if
breakpoint moves
https://bugs.webkit.org/show_bug.cgi?id=50813

Attachment 76188: Patch.
https://bugs.webkit.org/attachment.cgi?id=76188&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76188&action=review

> WebCore/inspector/front-end/SourceFrame.js:452
> +	   lineNumber -= 1;

Why do you need this? It should be extracted into a method with descriptive
name.


More information about the webkit-reviews mailing list