[webkit-reviews] review denied: [Bug 51100] [QT] QtWebkit geolocation's position.timestamp is not in miliseconds : [Attachment 76979] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 51100: [QT] QtWebkit geolocation's position.timestamp is not in miliseconds
https://bugs.webkit.org/show_bug.cgi?id=51100

Attachment 76979: patch
https://bugs.webkit.org/attachment.cgi?id=76979&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76979&action=review

> WebCore/platform/qt/GeolocationServiceQt.cpp:86
> -    m_lastPosition = Geoposition::create(coordinates.release(),
geoPosition.timestamp().toTime_t());
> +    m_lastPosition = Geoposition::create(coordinates.release(),
geoPosition.timestamp().toMSecsSinceEpoch());

toMSecsSinceEpoch() is new in Qt 4.7. Since we still support building QtWebKit
against Qt 4.6, this needs a QT_VERSION check and something for 4.6.