[webkit-reviews] review denied: [Bug 49750] [Qt] Compile with QT_NO_GRAPHICSVIEW : [Attachment 74261] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Sam Magnuson
<smagnuso at gmail.com>'s request for review:
Bug 49750: [Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

Attachment 74261: Patch
https://bugs.webkit.org/attachment.cgi?id=74261&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74261&action=review

The patch does not seem to apply r- for that (file WebKit/qt/ChangeLog).

How have you tested the patch ?

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:119
> +#if !defined(QT_NO_GRAPHICSVIEW)

Is this needed if USE(ACCELERATED_COMPOSITING) or USE(TEXTURE_MAPPER) is false
?

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:259
> +#if !defined(QT_NO_GRAPHICSVIEW)

Ditto.