[webkit-reviews] review denied: [Bug 51279] Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces : [Attachment 76922] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 51279: Add setNeedsStyleRecalc for getting canvas contexts that use
IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=51279

Attachment 76922: Patch
https://bugs.webkit.org/attachment.cgi?id=76922&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76922&action=review

> WebCore/ChangeLog:9
> +	   No new tests. Current canvas layout tests sufficient.

If you're fixing a bug here, that's not true.

> WebCore/platform/graphics/ImageBuffer.h:43
> -#define USE_IOSURFACE 1
> +#define WTF_USE_IOSURFACE 1

USE(IOSURFACE) is too vague when read out of context. It should be something
like USE(IOSURFACE_CANVAS_BACKING_STORE) or something.

It's also rare, not not unknown, to #define a WTF macro outside of config.h