[webkit-reviews] review granted: [Bug 48539] Support the text-emphasis CSS property : [Attachment 76852] Part 4: Layout and rendering

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 48539: Support the text-emphasis CSS property
https://bugs.webkit.org/show_bug.cgi?id=48539

Attachment 76852: Part 4: Layout and rendering
https://bugs.webkit.org/attachment.cgi?id=76852&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76852&action=review

r=me!

> WebCore/rendering/InlineFlowBox.cpp:754
> +    if (style->textEmphasisMark() != TextEmphasisMarkNone) {
> +	   int emphasisMarkHeight =
style->font().emphasisMarkHeight(style->textEmphasisMarkString());
> +	   if (style->textEmphasisPosition() == TextEmphasisPositionOver)
> +	       topGlyphOverflow = min(topGlyphOverflow, -emphasisMarkHeight);
> +	   else
> +	       bottomGlyphOverflow = max(bottomGlyphOverflow,
emphasisMarkHeight);
> +    }

It would be great to have a repaint test that tests the overflow repainting.