[webkit-reviews] review granted: [Bug 40945] WebSocket errors should be logged to console : [Attachment 76866] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 40945: WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=40945

Attachment 76866: Patch
https://bugs.webkit.org/attachment.cgi?id=76866&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+ws://nonexistent.domain.invalid:80/WebSocket network error: error code 2
(Operation could not be completed. (kCFErrorDomainCFNetwork error 2.))

It isn't great to print the almost useless error code twice.

This bug is originally about invalid SSL certificates. Did you check that a
useful message is printed for those? How does it look?

+#ifdef BUILDING_ON_TIGER

Please put modern code first, and Tiger specific in a fallback branch (i.e.
please reverse both ifdefs).

This is definitely an improvement, r=me. Please do check that this addresses
the original issue reported here (printing an error for SSL certificates).