[webkit-reviews] review denied: [Bug 51243] Web Inspector: can't set breakpoints if resource content is loaded too fast : [Attachment 76870] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 17 06:19:12 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51243: Web Inspector: can't set breakpoints if resource content is loaded
too fast
https://bugs.webkit.org/show_bug.cgi?id=51243

Attachment 76870: Patch.
https://bugs.webkit.org/attachment.cgi?id=76870&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76870&action=review

> WebCore/inspector/front-end/ScriptsPanel.js:259
> +		   var view =
WebInspector.ResourceManager.resourceViewForResource(resource);

You should use WebInspector.ResourceManager.existingResourceViewForResource not
to create it unless necessary.


More information about the webkit-reviews mailing list