[webkit-reviews] review granted: [Bug 50536] [Qt] Fix caret browsing navigation mode : [Attachment 75677] patch v2 - it builds and has no style issues.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 16 17:49:36 PST 2010
Ariya Hidayat <ariya.hidayat at gmail.com> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 50536: [Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536
Attachment 75677: patch v2 - it builds and has no style issues.
https://bugs.webkit.org/attachment.cgi?id=75677&action=review
------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75677&action=review
LGTM.
>
LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt
:1
> +This tests that arrow keys navigatie through a paragraph as expected when in
caret browsing mode, also with shift and ctrl modifiers.
"navigate"
More information about the webkit-reviews
mailing list