[webkit-reviews] review granted: [Bug 50985] [chromium] useless warnings when building on Windows : [Attachment 76451] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 16 16:01:02 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 50985: [chromium] useless warnings when building on Windows
https://bugs.webkit.org/show_bug.cgi?id=50985
Attachment 76451: Patch
https://bugs.webkit.org/attachment.cgi?id=76451&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit code uses 'this' in initializer lists pretty freely. I think it is
reasonable to
suppress this warning consistently in WebKit. I also think it is reasonable to
raise
this issue for discussion on #webkit to see if folks have interest in
introducing a
macro like Chromium's ALLOW_THIS_IN_INITIALIZER_LIST.
More information about the webkit-reviews
mailing list