[webkit-reviews] review granted: [Bug 51133] Provide an interface to force using fullscreen mediaplayer : [Attachment 76802] updated with Jer's suggestion

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 51133: Provide an interface to force using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133

Attachment 76802: updated with Jer's suggestion
https://bugs.webkit.org/attachment.cgi?id=76802&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76802&action=review

r+, but clearing the cq flag because I would like the ChangeLog comment to be
accurate. 

Thanks for the change!

> WebCore/ChangeLog:13
> +	   No new tests needed since there is no functionality change.

This is not true, there is definitely new functionality and it will be possible
to create new tests once a platform implements
requiresFullscreenForVideoPlayback. Probably better to say something like "No
new tests because no client implements requiresFullscreenForVideoPlayback yet".