[webkit-reviews] review granted: [Bug 50517] Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal : [Attachment 75607] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted  review:
Bug 50517: Add a fast case for ASCII strings in
HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517

Attachment 75607: Patch
https://bugs.webkit.org/attachment.cgi?id=75607&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75607&action=review

I think it’s OK to land this patch. I’m going to change the review to review+.
Eric, please do let me know if you object. I am not trying to override you.

> JavaScriptCore/wtf/text/AtomicString.cpp:235
> +	       return equalUTF16WithUTF8(string->characters(),
string->characters() + string->length(), buffer.characters, buffer.characters +
buffer.length);

We have stringCharacters in a local variable, and should use it instead of
string->characters().