[webkit-reviews] review denied: [Bug 51193] IndexedDB: Support Date objects as keys. : [Attachment 76777] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 51193: IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

Attachment 76777: Patch
https://bugs.webkit.org/attachment.cgi?id=76777&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76777&action=review

> LayoutTests/storage/indexeddb/objectstore-basics.html:165
> +    result = evalAndLog("store.add({x: new Date(), y: 'value'}, 'key')");

Maybe test passing in a specific date and verify it comes out as expected?

> WebCore/storage/IDBKey.h:43
> +	   IDBKey* idbKey = new IDBKey();

Adopt it right away and store it in a ref ptr.	.release() in the return